Skip to content

Shapes: Refactored ShapeAttribute to use new GeometryAttribute #2914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 15, 2025
Merged

Shapes: Refactored ShapeAttribute to use new GeometryAttribute #2914

merged 8 commits into from
Oct 15, 2025

Conversation

@gregoire-dl
Copy link
Member

@gregoire-dl gregoire-dl commented Oct 9, 2025

Important

This pull request is based on #2913.

Description

This pull request introduces the GeometryAttribute, which inherits from GroupAttribute.
These new attributes encapsulate the concept of geometry.
ShapeAttribute has been updated to make use of these new attributes and to add new features such as:

  • Serialization of color within ShapeAttribute
  • The ability to rename ShapeAttribute instances

Both ShapeViewer and ShapeEditor have been modified to accommodate these changes.
Additionally, this pull request improves the visibility of shapes in the ShapeViewer, making it easier to interact with them.

Unit tests:

  • ShapeAttribute unit tests have been modified to accommodate these changes.

Samples:

Features list

  • Add new GeometryAttribute.
  • Add Size2d and Vec2d attribute descriptions.
  • Update ShapeAttribute and ShapeAttribute attribute descriptions.
  • Update ShapeAttribute unit tests.
  • Add ShapeAttribute user color serialization.
  • Add ShapeAttribute user name serialization.
  • Allow user to edit shape name in ShapeEditor.
  • Improve Point2d display in ShapeViewer.
  • Improve Handle display in ShapeViewer.

Implementation remarks

@gregoire-dl gregoire-dl added this to the Meshroom 2026.1.0 milestone Oct 9, 2025
@gregoire-dl gregoire-dl self-assigned this Oct 9, 2025
@codecov
Copy link

codecov bot commented Oct 9, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 98.49624% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.78%. Comparing base (f939161) to head (e025862).
⚠️ Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
meshroom/core/attribute.py 93.93% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2914      +/-   ##
===========================================
+ Coverage    80.74%   80.78%   +0.03%     
===========================================
  Files           55       56       +1     
  Lines         7728     7749      +21     
===========================================
+ Hits          6240     6260      +20     
- Misses        1488     1489       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cbentejac cbentejac merged commit e54eadd into develop Oct 15, 2025
4 checks passed
@cbentejac cbentejac deleted the dev/shapesGeo branch October 15, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbentejac cbentejac cbentejac approved these changes

Assignees

@gregoire-dl gregoire-dl

Labels

review type:enhancement

Projects

None yet

Milestone

Meshroom 2026.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@gregoire-dl @cbentejac